Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Policy: Added new class for creation of centralized policy lists and vSmart policy #222

Merged
merged 16 commits into from
Sep 19, 2023
Merged

Policy: Added new class for creation of centralized policy lists and vSmart policy #222

merged 16 commits into from
Sep 19, 2023

Conversation

ravindra-h
Copy link
Collaborator

@ravindra-h ravindra-h commented Apr 24, 2023 •
edited by sbasan
Loading

Pull Request summary:

Policy: endpoint support for selected centralized policy lists and vSmart policy

Description of changes:

  • Create, get all, get details, delete
    • Data prefix list
    • Site list
    • VPN list
    • Data / traffic policy
  • Create, activate, deactivate
    • vSmart policy
    • vSmart CLI policy

Checklist:

  • Make sure to run pre-commit before commiting changes
  • Make sure all checks have passed
  • PR description is clear and comprehensive
  • Mentioned the issue that this PR solves (if applicable)
  • Make sure you test the changes

kagrski
kagrski suggested changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@kagrski kagrski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-check PR and provide the typing for variables.

vmngclient/api/policy_list.py Outdated Show resolved Hide resolved
vmngclient/api/policy_list.py Outdated Show resolved Hide resolved
vmngclient/api/policy_list.py Outdated Show resolved Hide resolved
vmngclient/api/policy_list.py Outdated Show resolved Hide resolved
vmngclient/api/policy_list.py Outdated Show resolved Hide resolved
vmngclient/api/policy_list.py Outdated Show resolved Hide resolved
vmngclient/api/policy_list.py Outdated Show resolved Hide resolved
vmngclient/api/policy_list.py Outdated Show resolved Hide resolved
vmngclient/api/policy_list.py Outdated Show resolved Hide resolved
vmngclient/api/policy_list.py Outdated Show resolved Hide resolved
@sbasan sbasan force-pushed the ravinh_2023_04_24 branch 2 times, most recently from 7b3c6e9 to 754faed Compare September 4, 2023 19:20
@sbasan sbasan force-pushed the ravinh_2023_04_24 branch 2 times, most recently from fa5a655 to ed702f3 Compare September 12, 2023 21:24
@sbasan sbasan requested a review from kagrski September 15, 2023 16:27
ravindra-h and others added 16 commits September 19, 2023 11:29
@ravindra-h @sbasan
Policy: Added new class for creation of centralized policy with follo…
d1b7f3d 
…wing API support

- Create, get all, get details, delete
-- Data prefix list
-- Site list
-- VPN list
-- Data / traffic policy
- Create, activate, deactivate
-- vSmart policy
-- vSmart CLI policy
@sbasan
define common models for policy list builder endpoints
7f9daaa
@sbasan
add: dataprefix policy list builder endpoints
b476384
@sbasan
update: ENDPOINTS.md after rebase
8494fad
@sbasan
add: site policy list builder endpoints
ad32c58
@sbasan
add validation of name field, description is optional
b603f72
@sbasan
add: vpn policy list builder endpoints
4fb14ba
@sbasan
remove reused fields in policy_list common model
09fb7e6
@sbasan
wip: data policy definition builder endpoints
a6e7f3d
@sbasan
add: traffic-policy model (Sequence can be reused)
baf2ccc
@sbasan
update: data policy definition builder endpoints and models
dd1981f
@sbasan
fix: ipPrefix is IPv4 only
972d053
@sbasan
fix validators
866df61
@sbasan
fix: request decorator was not using default arguments values
27be8a5
@sbasan
add: vsmart template (centralized) policy endpoints
31ef526
@sbasan
remove: policy list api prototype
34d8252
sbasan
sbasan approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@sbasan sbasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modelled endpoints

@sbasan sbasan merged commit 4844e84 into main Sep 19, 2023
9 checks passed
@sbasan sbasan deleted the ravinh_2023_04_24 branch September 19, 2023 12:15
@JimOverholt JimOverholt mentioned this pull request Apr 25, 2024
Closed
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbasan sbasan sbasan approved these changes

@dariuszniedzielski-codilime dariuszniedzielski-codilime dariuszniedzielski-codilime approved these changes

@kagrski kagrski kagrski approved these changes

@JimOverholt JimOverholt Awaiting requested review from JimOverholt JimOverholt is a code owner

@igosoft igosoft Awaiting requested review from igosoft igosoft is a code owner

@bboot2 bboot2 Awaiting requested review from bboot2 bboot2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ravindra-h @kagrski @dariuszniedzielski-codilime @sbasan